CheckTxLogs Uses existing mechanisms to extract transactions from multiple logs #7611
Conversation
|
NOTE: The compilation error in |
| * @param logVersionCallback will be kept up to date with which log version the cursor is at. | ||
| */ | ||
| public static LogEntryCursor openLogs( final FileSystemAbstraction fs, File storeDirectory, | ||
| final AtomicLong logVersionCallback ) |
There was a problem hiding this comment.
This current log version callback does not look pretty. Can this method instead return a thing that extends LogEntryCursor with a method like getCurrentLogVersion()? Or this method can be added to LogEntryCursor itself.
There was a problem hiding this comment.
I agree, it doesn't. However it's simply a test utility. Your suggestion sounds good though, lemme try that.
EDIT: there's actually no precise way of determining the log version of a given entry. Hooking in on the version bridge is currently the best way to do this. Perhaps just provide a nicer callback thing instead of AtomicLong?
ANOTHER EDIT: I'm wrong, the cursor already have the channel and all that, should be simple to add.
|
@tinwelint review round completed. I think we should change the mutable long callback thing. |
…tiple logs instead of checking each individual log file. Reason being that order is vital to correct results and less and simpler code in CheckTxLogs as well.
tinwelint
force-pushed
the
2.3-simpler-check-tx-logs
branch
from
c80105d
to
42f6ce8
Compare
|
@lutovich changed things all for the better imho, have another look |
instead of checking each individual log file. Reason being that order is vital
to correct results and less and simpler code in CheckTxLogs as well.