New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore compatibility within BOLT protocol v1 #8050

Closed
wants to merge 1 commit into
base: 3.1
from

Conversation

Projects
None yet
5 participants
@cleishm
Contributor

cleishm commented Sep 28, 2016

This PR restores compatibility with previous releases of the BOLT protocol v1.

Specifically, it allows a FAILURE of INIT to be acknowledged by the client, thus clearing the failure state. Failure of INIT is a common error path, easily reached by a user error, and thus maintaining correct protocol behaviour is important and necessary for compatibility.

Restore compatibility within BOLT protocol v1
This commit restores compatibility with previous releases of the BOLT
protocol v1.

Specifically, it allows a FAILURE of INIT to be acknowledged by the
client, thus clearing the failure state. Failure of INIT is a common
error path, easily reached by a user error, and thus maintaining correct
protocol behaviour is important and necessary for compatibility.
@systay

This comment has been minimized.

Show comment
Hide comment
@systay

systay Dec 8, 2016

Member

Let's re-open this if/when we decide to accept the changes. No need to have long opened PRs that are not acted on.

Member

systay commented Dec 8, 2016

Let's re-open this if/when we decide to accept the changes. No need to have long opened PRs that are not acted on.

@systay systay closed this Dec 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment