Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore compatibility within BOLT protocol v1 #8050

Closed
wants to merge 1 commit into from

Conversation

@cleishm
Copy link
Contributor

@cleishm cleishm commented Sep 28, 2016

This PR restores compatibility with previous releases of the BOLT protocol v1.

Specifically, it allows a FAILURE of INIT to be acknowledged by the client, thus clearing the failure state. Failure of INIT is a common error path, easily reached by a user error, and thus maintaining correct protocol behaviour is important and necessary for compatibility.

@davidegrohmann davidegrohmann added the 3.1 label Sep 29, 2016
@cleishm cleishm force-pushed the cleishm:3.1-bolt-v1-compatibility branch 2 times, most recently from 5027254 to f0abe57 Oct 15, 2016
@cleishm cleishm force-pushed the cleishm:3.1-bolt-v1-compatibility branch from f0abe57 to b85896f Nov 5, 2016
This commit restores compatibility with previous releases of the BOLT
protocol v1.

Specifically, it allows a FAILURE of INIT to be acknowledged by the
client, thus clearing the failure state. Failure of INIT is a common
error path, easily reached by a user error, and thus maintaining correct
protocol behaviour is important and necessary for compatibility.
@cleishm cleishm force-pushed the cleishm:3.1-bolt-v1-compatibility branch from b85896f to d15df05 Dec 3, 2016
@systay
Copy link
Member

@systay systay commented Dec 8, 2016

Let's re-open this if/when we decide to accept the changes. No need to have long opened PRs that are not acted on.

@systay systay closed this Dec 8, 2016
lucis-fluxum added a commit to lucis-fluxum/bolt-rs that referenced this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.