PropertyRecord.getType() now returns PropertyType instead of int #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading the property type and converting to a PropertyType value requires bit shifting and masking that is not achieved by simply using the type int value as read from disk. This can lead to improper identification of the record type during recovery, among other scenarios. This patch changes the PropertyRecord.getType() method to return PropertyType, properly parsed. It adds a getTypeAsInt() method to allow for access to the raw int value for serialization purposes.
tinwelint
approved these changes
Feb 7, 2017
|
Replaced by #8780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the property type and converting to a PropertyType value
requires bit shifting and masking that is not achieved by simply
using the type int value as read from disk. This can lead to
improper identification of the record type during recovery, among
other scenarios.
This patch changes the PropertyRecord.getType() method to return
PropertyType, properly parsed. It adds a getTypeAsInt() method
to allow for access to the raw int value for serialization
purposes.