Lots of changes to support the new session API in neo4j-core #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See neo4jrb/neo4j-core#247 for some of what's going on here |
Conflicts: lib/neo4j/shared/persistence.rb neo4j.gemspec
Conflicts: lib/neo4j/active_node/id_property.rb lib/neo4j/active_node/node_wrapper.rb lib/neo4j/active_node/persistence.rb lib/neo4j/railtie.rb neo4j.gemspec spec/e2e/active_model_spec.rb spec/e2e/active_rel/persistence/query_factory_spec.rb spec/e2e/has_many_spec.rb spec/e2e/migration_spec.rb spec/e2e/query_spec.rb spec/spec_helper.rb spec/unit/active_node/validation_spec.rb spec/unit/shared/identity_spec.rb
Conflicts: lib/neo4j/migration.rb spec/e2e/has_many_spec.rb
|
Yay, this seems to be finally working! Thanks a lot for help from @ProGM ! I think that it's reporting as not passing because of issues loading @subvertallchris and @ProGM would you like to look over this PR before we merge it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still have a ways to go...
Checklist of things to remember: