Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed dependency to will_paginate, locked to 3.0.pre4 (newly released…

… 3.0.0 does not work yet with neo4j.rb)
  • Loading branch information...
commit fb86d975da1034fde3a3828b5f6e511f7460e09a 1 parent e9c4337
@andreasronge andreasronge authored
Showing with 3 additions and 2 deletions.
  1. +3 −2 neo4j.gemspec
View
5 neo4j.gemspec
@@ -17,7 +17,8 @@ Gem::Specification.new do |s|
s.summary = "A graph database for JRuby"
s.description = <<-EOF
You can think of Neo4j as a high-performance graph engine with all the features of a mature and robust database.
-The programmer works with an object-oriented, flexible network structure rather than with strict and static tables — yet enjoys all the benefits of a fully transactional, enterprise-strength database.
+The programmer works with an object-oriented, flexible network structure rather than with strict and static tables
+yet enjoys all the benefits of a fully transactional, enterprise-strength database.
It comes included with the Apache Lucene document database.
EOF
@@ -30,6 +31,6 @@ It comes included with the Apache Lucene document database.
s.add_dependency('orm_adapter', ">= 0.0.3")
s.add_dependency("activemodel", ">= 3.0.0")
- s.add_dependency("will_paginate", ["~>3.0.pre"])
+ s.add_dependency("will_paginate", ["3.0.pre4"]) # should be ~>3.0 but it's API has changed '
s.add_dependency("railties", ">= 3.0.0")
end

5 comments on commit fb86d97

@prezently

After updating to 1.1.3 I now get this error:
LoadError: no such file to load -- will_paginate/finders/base

I'm guessing that's related to this change? Should this change be backported to the 1.1.3 release?

@prezently

To answer my own question, yes, that did seem to be the problem. I hand-edited the gemspec in my gem dir and also edited my Gemfile.lock to point at 3.0.pre4 and that fixed my problem.

@andreasronge

It was not related to 1.1.3 release. I happend to release at the same time as the will_paginate was released.

@prezently

Gotcha. I guess my point is that 1.1.3 is currently broken as it stands with the will_paginate problem. While your followup commit fixes the breakage, there's no release tag to point to that contains that fix. What I probably should have said rather than "backport" was whether you'd cut a new release (1.1.3.1?) that contains the dependency change.

@andreasronge

I have released 1.1.4

Please sign in to comment.
Something went wrong with that request. Please try again.