New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of changes to support the new session API in neo4j-core #1095

Merged
merged 93 commits into from Aug 2, 2016

Conversation

Projects
None yet
3 participants
@cheerfulstoic
Member

cheerfulstoic commented Dec 30, 2015

Still have a ways to go...

Checklist of things to remember:

  • Migrations / label objects should support different kinds of constraints (unique, property existance, etc...)
@cheerfulstoic

This comment has been minimized.

Member

cheerfulstoic commented Dec 30, 2015

See neo4jrb/neo4j-core#247 for some of what's going on here

cheerfulstoic added some commits Jan 4, 2016

Merge branch 'master' into new_cypher_api
Conflicts:
	lib/neo4j/shared/persistence.rb
	neo4j.gemspec
Merge branch 'master' into new_cypher_api
Conflicts:
	lib/neo4j/active_node/id_property.rb
	lib/neo4j/active_node/node_wrapper.rb
	lib/neo4j/active_node/persistence.rb
	lib/neo4j/railtie.rb
	neo4j.gemspec
	spec/e2e/active_model_spec.rb
	spec/e2e/active_rel/persistence/query_factory_spec.rb
	spec/e2e/has_many_spec.rb
	spec/e2e/migration_spec.rb
	spec/e2e/query_spec.rb
	spec/spec_helper.rb
	spec/unit/active_node/validation_spec.rb
	spec/unit/shared/identity_spec.rb
Merge branch 'master' into new_cypher_api
Conflicts:
	lib/neo4j/migration.rb
	spec/e2e/has_many_spec.rb
@cheerfulstoic

This comment has been minimized.

Member

cheerfulstoic commented Jul 30, 2016

Yay, this seems to be finally working! Thanks a lot for help from @ProGM ! I think that it's reporting as not passing because of issues loading neo4j-core from the travis build which is what we'd get when we'd merge to master. When we do that we can fix the Gemfile

@subvertallchris and @ProGM would you like to look over this PR before we merge it into master? Don't forget that there is this PR on neo4j-core

@cheerfulstoic cheerfulstoic merged commit f2e93f0 into master Aug 2, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@cheerfulstoic cheerfulstoic deleted the new_cypher_api branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment