New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of NEO4J_TYPE environment variable to match documentation #1235

Merged
merged 1 commit into from Jul 10, 2016

Conversation

Projects
None yet
2 participants
@bloomdido
Contributor

bloomdido commented Jul 9, 2016

Fixes #1234

This pull introduces/changes:

  • Correctly check the value of NEO4J_TYPE environment variable

Pings:
@cheerfulstoic
@subvertallchris

@cheerfulstoic

This comment has been minimized.

Show comment
Hide comment
@cheerfulstoic

cheerfulstoic Jul 10, 2016

Member

Awesome, thanks!

I generally prefer the NEO4J_URL or NEO4J_PATH variables, but this should definitely also work. Will cherry-pick to a release

Member

cheerfulstoic commented Jul 10, 2016

Awesome, thanks!

I generally prefer the NEO4J_URL or NEO4J_PATH variables, but this should definitely also work. Will cherry-pick to a release

@cheerfulstoic cheerfulstoic merged commit 277e29c into neo4jrb:master Jul 10, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment