New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

methods to clear cached classes after `reload!` is called #855

Merged
merged 2 commits into from Jul 3, 2015

Conversation

Projects
None yet
3 participants
@subvertallchris
Member

subvertallchris commented Jul 3, 2015

This appears to correct the root cause of #717 and possibly neo4jrb/devise-neo4j#16. It uses the before_remove_const method fired by ActiveSupport's reload! to wipe cached references to classes. It's possible others are still lurking but this will be a start.

subvertallchris added a commit that referenced this pull request Jul 3, 2015

Merge pull request #855 from neo4jrb/constantize_problem
methods to clear cached classes after `reload!` is called

@subvertallchris subvertallchris merged commit 05abc10 into master Jul 3, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@subvertallchris subvertallchris deleted the constantize_problem branch Jul 8, 2015

@jacobwgillespie

This comment has been minimized.

Show comment
Hide comment
@jacobwgillespie

jacobwgillespie Aug 11, 2015

Contributor

Any news on when this PR might get released on Rubygems? Right now, using reload! in the console isn't working with the current version (5.0.14) and it looks like it's due to this not yet being released.

Contributor

jacobwgillespie commented Aug 11, 2015

Any news on when this PR might get released on Rubygems? Right now, using reload! in the console isn't working with the current version (5.0.14) and it looks like it's due to this not yet being released.

@cheerfulstoic

This comment has been minimized.

Show comment
Hide comment
@cheerfulstoic

cheerfulstoic Aug 12, 2015

Member

We definitely want to release a 5.1 soon. I've been producing some screencasts for the gems and the latest screencasts require some features in master, so those will need to be made publicly accessible.

Member

cheerfulstoic commented Aug 12, 2015

We definitely want to release a 5.1 soon. I've been producing some screencasts for the gems and the latest screencasts require some features in master, so those will need to be made publicly accessible.

@cheerfulstoic

This comment has been minimized.

Show comment
Hide comment
@cheerfulstoic

cheerfulstoic Aug 12, 2015

Member

To give a clearer answer: I expect we'll at least do an RC that'll be in the next week or two, one way or another.

Member

cheerfulstoic commented Aug 12, 2015

To give a clearer answer: I expect we'll at least do an RC that'll be in the next week or two, one way or another.

@jacobwgillespie

This comment has been minimized.

Show comment
Hide comment
@jacobwgillespie

jacobwgillespie Aug 12, 2015

Contributor

Ah, gotcha, so this is going out as a point release and not a patch. Thank you for the work, I'll watch for the RC!

Contributor

jacobwgillespie commented Aug 12, 2015

Ah, gotcha, so this is going out as a point release and not a patch. Thank you for the work, I'll watch for the RC!

@cheerfulstoic

This comment has been minimized.

Show comment
Hide comment
@cheerfulstoic

cheerfulstoic Aug 12, 2015

Member

Ah, right. I'm not sure if @subvertallchris planned to do a patch (I know he's been busy with work lately), but obviously it will go out with a point release ;) Thanks for the patience

Member

cheerfulstoic commented Aug 12, 2015

Ah, right. I'm not sure if @subvertallchris planned to do a patch (I know he's been busy with work lately), but obviously it will go out with a point release ;) Thanks for the patience

@subvertallchris

This comment has been minimized.

Show comment
Hide comment
@subvertallchris

subvertallchris Aug 12, 2015

Member

I think a patch release would be a good idea. A few people are locked to the specific commit that fixed it because they need what it provides, I think it would help them out. I'll take care of it when I have a few minutes today and will post here when it's done.

Member

subvertallchris commented Aug 12, 2015

I think a patch release would be a good idea. A few people are locked to the specific commit that fixed it because they need what it provides, I think it would help them out. I'll take care of it when I have a few minutes today and will post here when it's done.

@jacobwgillespie

This comment has been minimized.

Show comment
Hide comment
@jacobwgillespie

jacobwgillespie Aug 12, 2015

Contributor

👍 Thank you!

Contributor

jacobwgillespie commented Aug 12, 2015

👍 Thank you!

@subvertallchris

This comment has been minimized.

Show comment
Hide comment
@subvertallchris

subvertallchris Aug 12, 2015

Member

Just released 5.0.15 with this. Let us know if you have any trouble.

Member

subvertallchris commented Aug 12, 2015

Just released 5.0.15 with this. Let us know if you have any trouble.

@cheerfulstoic

This comment has been minimized.

Show comment
Hide comment
@cheerfulstoic
Member

cheerfulstoic commented Aug 12, 2015

@subvertallchris: CHANGELOG? ;)

@jacobwgillespie

This comment has been minimized.

Show comment
Hide comment
@jacobwgillespie

jacobwgillespie Aug 12, 2015

Contributor

It works great - thanks! 🎉

Contributor

jacobwgillespie commented Aug 12, 2015

It works great - thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment