New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added waitUntil to puppeteer.goto #45

Closed
wants to merge 2 commits into
base: master
from

Conversation

1 participant
@ycmjason
Copy link

ycmjason commented May 12, 2018

Thank you so much for making this package! This package is what makes faviator possible! 馃槃

SVG may include css styles. To facilitate @import in css, we should wait until the network is idle before doing the screenshot.

Added waitUntil to puppeteer.goto
SVG may include css styles. To facilitate `@import` in css, we should wait until the network is idle before doing the screenshot.
@ycmjason

This comment has been minimized.

Copy link

ycmjason commented May 12, 2018

@neocotic Hope you won't mind, but if you approve the change, can you roll out a patch? I have a bug to fix in another package which is introduced by this.

@ycmjason

This comment has been minimized.

Copy link

ycmjason commented May 12, 2018

Inspected a little bit and I couldn't fix the test failed. I don't think this is because of my PR tho. I tried cloning master and run the tests and they still fail.

Would want more advice on this. Thank you.

@ycmjason ycmjason referenced this pull request May 12, 2018

Closed

Font file not loaded #7

@ycmjason

This comment has been minimized.

Copy link

ycmjason commented Jul 2, 2018

never mind 馃槃 I have implemented my own version.

https://www.npmjs.com/package/@ycm.jason/svg-to-img

@ycmjason ycmjason closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment