Skip to content

Conversation

TelepathicGrunt
Copy link
Contributor

As far as I can tell with a global GitHub search, I was able to find only about 4 mods that actually implemented IFluidBlock. Only 1 of which was actually returning some fluid data. The rest were returning 0 or null for fluids from the interface methods.

So as far as we can tell, IFluidBlock is ridiculously unused and pretty much dead code. So this PR does some cleanup of removing it. If someone had a use case for needing this interface for their block, they can reach out to use so we can get details ont heir use case and come up with a more modern and intuitive solution better than IFluidBlock.

Closes #1013

@TelepathicGrunt TelepathicGrunt self-assigned this May 27, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 27, 2024

  • Publish PR to GitHub Packages

Last commit published: 8655e4d40cce4ba4811fa7e90c2f35830f1e2390.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1024' // https://github.com/neoforged/NeoForge/pull/1024
        url 'https://prmaven.neoforged.net/NeoForge/pr1024'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1024.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1024
cd NeoForge-pr1024
curl -L https://prmaven.neoforged.net/NeoForge/pr1024/net/neoforged/neoforge/20.6.111-beta-pr-1024-RemoveIFluidBlock/mdk-pr1024.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@TelepathicGrunt TelepathicGrunt added cleanup Change that isn't an enhancement or a bug fix breaking change Breaks binary compatibility 1.20.6 Targeted at Minecraft 1.20.6 labels May 27, 2024
@pupnewfster pupnewfster added the last call Planned to be resolved by the end of the week, awaiting any last-minute comments label May 29, 2024
pupnewfster added a commit to mekanism/Mekanism that referenced this pull request May 29, 2024
@pupnewfster pupnewfster merged commit ce84b2d into neoforged:1.20.x Jun 5, 2024
@TelepathicGrunt TelepathicGrunt deleted the RemoveIFluidBlock branch June 12, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.6 Targeted at Minecraft 1.20.6 breaking change Breaks binary compatibility cleanup Change that isn't an enhancement or a bug fix last call Planned to be resolved by the end of the week, awaiting any last-minute comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove IFluidBlock?
3 participants