From a3d8baeb3ba78ff96ea7f0bc21d22c75a3af974f Mon Sep 17 00:00:00 2001 From: Sandro Ciervo Date: Thu, 19 Sep 2024 17:10:20 +0200 Subject: [PATCH 1/4] Track obsolete types with Analyzer, but don't break the build --- build/Neolution.CodeAnalysis.globalconfig | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/build/Neolution.CodeAnalysis.globalconfig b/build/Neolution.CodeAnalysis.globalconfig index de091b4..7c13a12 100644 --- a/build/Neolution.CodeAnalysis.globalconfig +++ b/build/Neolution.CodeAnalysis.globalconfig @@ -250,6 +250,10 @@ dotnet_diagnostic.S3267.severity = suggestion ; Developers should be warned when they create disposable objects without disposing them dotnet_diagnostic.CA2000.severity = warning +# S1133 Do not forget to remove this deprecated code someday. +; Deprecated code should eventually be removed, but it should not break the current build. +dotnet_diagnostic.CA2000.severity = suggestion + # S107: Methods should not have too many parameters dotnet_diagnostic.S107.severity = warning From 9c4303d4647ca53cb6634050c6e75c7af1924f16 Mon Sep 17 00:00:00 2001 From: Sandro Ciervo Date: Thu, 19 Sep 2024 17:24:30 +0200 Subject: [PATCH 2/4] Add comment in Changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index fe32e9e..43d2df1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and adheres to a project-specific [Versioning](/README.md). ## [Unreleased] +### Changed + +- Updated `S1133` to `suggestion`, because while we do want deprecated code to be removed eventually, it should not break the current build to mark a type as obsolete. + ## [3.1.0] - 2024-09-19 ### Fixed From 5ea6d0193942fef1a1c24a203f81b1d1074aa979 Mon Sep 17 00:00:00 2001 From: Sandro Ciervo Date: Thu, 19 Sep 2024 17:27:07 +0200 Subject: [PATCH 3/4] Actually change the rule --- build/Neolution.CodeAnalysis.globalconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/Neolution.CodeAnalysis.globalconfig b/build/Neolution.CodeAnalysis.globalconfig index 7c13a12..8fd6179 100644 --- a/build/Neolution.CodeAnalysis.globalconfig +++ b/build/Neolution.CodeAnalysis.globalconfig @@ -252,7 +252,7 @@ dotnet_diagnostic.CA2000.severity = warning # S1133 Do not forget to remove this deprecated code someday. ; Deprecated code should eventually be removed, but it should not break the current build. -dotnet_diagnostic.CA2000.severity = suggestion +dotnet_diagnostic.S1133.severity = suggestion # S107: Methods should not have too many parameters dotnet_diagnostic.S107.severity = warning From 256875c646baf42d8ba7477db39b7e1d59581037 Mon Sep 17 00:00:00 2001 From: Sandro Ciervo Date: Thu, 19 Sep 2024 17:32:09 +0200 Subject: [PATCH 4/4] rephrase --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 43d2df1..da4821b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ and adheres to a project-specific [Versioning](/README.md). ### Changed -- Updated `S1133` to `suggestion`, because while we do want deprecated code to be removed eventually, it should not break the current build to mark a type as obsolete. +- Updated `S1133` to `suggestion`, because while we do want deprecated code to be removed eventually, marking code as obsolete should not immediately break the build. ## [3.1.0] - 2024-09-19