Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out when an mbox/mmdf mailbox is a pipe #2323

Merged
merged 1 commit into from May 11, 2020
Merged

Error out when an mbox/mmdf mailbox is a pipe #2323

merged 1 commit into from May 11, 2020

Conversation

nabijaczleweli
Copy link
Member

@nabijaczleweli nabijaczleweli commented May 8, 2020

Otherwise hangs indefinitely, requiring SIGKILL

Fixes #2318

@nabijaczleweli nabijaczleweli requested a review from as a code owner May 8, 2020
Otherwise hangs indefinitely

Fixes #2318
@flatcap
Copy link
Member

@flatcap flatcap commented May 11, 2020

Thanks for the fix, @nabijaczleweli.
Your bug caused quite a bit of discussion on IRC:

  • how we should fix it
  • how we could make it work (it'd be a pain)
  • why neomutt locked up, but upstream mutt didn't

I've moved your fix out to mx_path_probe().
That puts it in the code path for all the mailboxes.
I've also added a gettext macro around the message for translation: _(...)

Thanks.

@flatcap flatcap merged commit 908c8b4 into neomutt:master May 11, 2020
4 of 10 checks passed
@nabijaczleweli nabijaczleweli deleted the lay_waste_to_pipe branch May 11, 2020
@nabijaczleweli
Copy link
Member Author

@nabijaczleweli nabijaczleweli commented May 12, 2020

Interesting; cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants