New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #211 & #247 - Updating documentation URL & merging RELEASE.md notes #257

Merged
merged 3 commits into from Oct 16, 2017

Conversation

Projects
None yet
2 participants
@SeanPrashad
Contributor

SeanPrashad commented Oct 15, 2017

Fixes #211 - the documentation URL for Neon's crate was 404'ing - one change was made to the documentation property in Cargo.toml to utilize the proper URL, found here.

Fixes #247 - merged old release notes (cli/RELEASES.md) into the current set of release notes (RELEASES.md), ensuring all cli PR's were explicitly stated and linked as appropriate. Also deleted the old RELEASE.md found in the cli folder!

@SeanPrashad SeanPrashad changed the title from Updated documentation URL to Fixes #211 - Updating documentation URL Oct 15, 2017

@SeanPrashad SeanPrashad changed the title from Fixes #211 - Updating documentation URL to Resolves #211 & #247 - Updating documentation URL & merge release notes Oct 15, 2017

@SeanPrashad SeanPrashad changed the title from Resolves #211 & #247 - Updating documentation URL & merge release notes to Resolves #211 & #247 - Updating documentation URL & merging RELEASE.md notes Oct 15, 2017

@dherman

This comment has been minimized.

Show comment
Hide comment
@dherman

dherman Oct 16, 2017

Collaborator

@SeanPrashad This is fantastic, thank you so much! It's really thorough. Just one request: can you also delete the cli/RELEASES.md file as part of this same PR?

Collaborator

dherman commented Oct 16, 2017

@SeanPrashad This is fantastic, thank you so much! It's really thorough. Just one request: can you also delete the cli/RELEASES.md file as part of this same PR?

@SeanPrashad

This comment has been minimized.

Show comment
Hide comment
@SeanPrashad

SeanPrashad Oct 16, 2017

Contributor

@dherman Deleted cli/RELEASED.md as requested!

Contributor

SeanPrashad commented Oct 16, 2017

@dherman Deleted cli/RELEASED.md as requested!

@dherman

This comment has been minimized.

Show comment
Hide comment
@dherman

dherman Oct 16, 2017

Collaborator

Thank you so much for your contribution!!

Collaborator

dherman commented Oct 16, 2017

Thank you so much for your contribution!!

@dherman dherman merged commit 82d1fd5 into neon-bindings:master Oct 16, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment