Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(create-neon): Improve docs generated by npm init neon project #771

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

kjvalencik
Copy link
Member

No description provided.

Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small wording suggestion.

@@ -39,7 +39,9 @@ export default class Package {
main: "index.node",
scripts: {
"build": "cargo-cp-artifact -nc index.node -- cargo build --message-format=json-render-diagnostics",
"install": "npm run build",
"build-debug": "npm run build --",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I really like how self-documenting this is.

create-neon/data/templates/README.md.hbs Outdated Show resolved Hide resolved
@kjvalencik kjvalencik merged commit 1d89872 into main Aug 6, 2021
@kjvalencik kjvalencik deleted the kv/release-mode-docs branch August 6, 2021 16:45
@kjvalencik kjvalencik mentioned this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants