Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borrow RFC #780

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Borrow RFC #780

merged 3 commits into from
Aug 30, 2021

Conversation

kjvalencik
Copy link
Member

Implementation of breaking changes to the Borrow API as proposed in neon-bindings/rfcs#44.

test/napi/lib/types.js Outdated Show resolved Hide resolved
@kjvalencik kjvalencik force-pushed the kv/rfc-borrow branch 5 times, most recently from ace03cd to 7f1b079 Compare August 26, 2021 21:03
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just one suggestion for the prelude.

src/types/buffer/lock.rs Outdated Show resolved Hide resolved
src/types/buffer/lock.rs Show resolved Hide resolved
test/napi/src/js/objects.rs Show resolved Hide resolved
src/prelude.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@kjvalencik kjvalencik merged commit 24e7d6f into next/0.10 Aug 30, 2021
@kjvalencik kjvalencik deleted the kv/rfc-borrow branch August 30, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants