Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI #893

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Simplify CI #893

merged 1 commit into from
Apr 29, 2022

Conversation

kjvalencik
Copy link
Member

@kjvalencik kjvalencik commented Apr 26, 2022

  • Remove clang dependency on Windows
  • Drop Node 12, add Node 18
  • Use latest npm 8
  • Drop Rust beta channel from the build matrix

I looked through a lot of history and the best I could tell, testing on beta has never caught a bug. Nightly is nice for new linting, but I chose to drop beta since it's redundant with nightly and will shrink the build matrix some.

* Remove clang dependency on Windows
* Drop Node 12, add Node 18
* Use latest npm 8
* Drop Rust beta channel from the build matrix
@@ -17,7 +17,7 @@ jobs:

strategy:
matrix:
node-version: [14.x]
node-version: [16.x]
Copy link
Member Author

@kjvalencik kjvalencik Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most recent LTS.

@@ -33,8 +33,6 @@ jobs:
- name: Use npm v8
# https://github.com/npm/cli/issues/4552
run: npm -g i npm@~8.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried updating this to the latest version, but the bug has not been fixed.

Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kjvalencik kjvalencik merged commit 01849a3 into main Apr 29, 2022
@kjvalencik kjvalencik deleted the kv/simplify-ci branch April 29, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants