From 9cfd09d36ee0de6d6b8d3193fc9adaf72aa9a5a3 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Thu, 14 Mar 2024 08:39:32 +0100 Subject: [PATCH] [DO NOT MERGE] CI: test with both io engines & vectored impls --- .github/workflows/build_and_test.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 810c61de2d1a..3e26b8aa16fa 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -452,6 +452,8 @@ jobs: matrix: build_type: [ debug, release ] pg_version: [ v14, v15, v16 ] + pageserver_virtual_file_io_engine: [ std-fs, tokio-epoll-uring ] + pageserver_get_vectored_impl: [ sequential, vectored ] steps: - name: Checkout uses: actions/checkout@v4 @@ -474,8 +476,8 @@ jobs: TEST_RESULT_CONNSTR: ${{ secrets.REGRESS_TEST_RESULT_CONNSTR_NEW }} CHECK_ONDISK_DATA_COMPATIBILITY: nonempty BUILD_TAG: ${{ needs.tag.outputs.build-tag }} - PAGESERVER_VIRTUAL_FILE_IO_ENGINE: tokio-epoll-uring - PAGESERVER_GET_VECTORED_IMPL: vectored + PAGESERVER_VIRTUAL_FILE_IO_ENGINE: ${{ matrix.pageserver_virtual_file_io_engine }} + PAGESERVER_GET_VECTORED_IMPL: ${{ matrix.pageserver_get_vectored_impl }} # Temporary disable this step until we figure out why it's so flaky # Ref https://github.com/neondatabase/neon/issues/4540 @@ -537,6 +539,8 @@ jobs: # the amount of groups (N) should be reflected in `extra_params: --splits N ...` pytest_split_group: [ 1, 2, 3, 4, 5 ] build_type: [ release ] + pageserver_virtual_file_io_engine: [ std-fs, tokio-epoll-uring ] + pageserver_get_vectored_impl: [ sequential, vectored ] steps: - name: Checkout uses: actions/checkout@v4 @@ -554,7 +558,8 @@ jobs: VIP_VAP_ACCESS_TOKEN: "${{ secrets.VIP_VAP_ACCESS_TOKEN }}" PERF_TEST_RESULT_CONNSTR: "${{ secrets.PERF_TEST_RESULT_CONNSTR }}" TEST_RESULT_CONNSTR: "${{ secrets.REGRESS_TEST_RESULT_CONNSTR_NEW }}" - PAGESERVER_VIRTUAL_FILE_IO_ENGINE: tokio-epoll-uring + PAGESERVER_VIRTUAL_FILE_IO_ENGINE: "${{ matrix.pageserver_virtual_file_io_engine }}" + PAGESERVER_GET_VECTORED_IMPL: ${{ matrix.pageserver_get_vectored_impl }} # XXX: no coverage data handling here, since benchmarks are run on release builds, # while coverage is currently collected for the debug ones