fix InvalidDNSNameError when using ip inside url #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works fine: get->url = "https://raw.githubusercontent.com/.../master/LICENSE-APACHE"
Fails: get->url = "https://151.101.0.133/.../master/LICENSE-APACHE"
with error: IoError(Custom { kind: Other, error: InvalidDNSNameError })
Requests should respect Host entry from request headers, following changes fixed it for me.
1.inside request.rs:
headers: HashMap<String, String>, => pub(crate) headers: HashMap<String, String>,
2.inside connection.rs:
let dns_name = &self.request.host; => let dns_name = self.request.headers.get("Host").unwrap_or(&self.request.host);