Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Defer event denormalization #251

Open
wants to merge 1 commit into
base: master
from

Conversation

@nlx-sascha
Copy link
Contributor

nlx-sascha commented Jan 1, 2020

Fixes: #241

Fixes: #241
Copy link
Member

bwaidelich left a comment

Thanks a lot for this one, too :)
To be honest I had a different approach in mind when creating the ticket (and should have documented that):
IMO everything "domain event" should be removed from the Event Store "sub package" so that it just deals with what we currently call RawEvents.
The (de)normalization would only have to take place when applying the event to a listener (if that listener really requires the domain event instance at all).

I'll amend the ticket description with some more thoughts but -1 this one for now because I'm still in the middle of a bigger refactoring that would clash.

Once 2.0 is released I'll work on the deferred (de)normalization and will share my insights/spikes asap!

@nlx-sascha

This comment has been minimized.

Copy link
Contributor Author

nlx-sascha commented Jan 2, 2020

Hey @bwaidelich thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.