New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add maxlength to TextArea view helper #1416

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@robertlemke
Copy link
Member

robertlemke commented Oct 23, 2018

This adds support for the maxlength property to TextArea.

Related to neos/form#87

Add maxlength to Text Area view helper
This support for the maxlenght property to TextArea.

Fixes neos/form#87

@robertlemke robertlemke requested a review from bwaidelich Oct 23, 2018

@robertlemke

This comment has been minimized.

Copy link
Member

robertlemke commented Oct 23, 2018

@bwaidelich like this? And if I'm not mistaken, this needs to go into master, right?

bwaidelich added a commit to bwaidelich/form that referenced this pull request Oct 23, 2018

@bwaidelich
Copy link
Member

bwaidelich left a comment

The minlength attribute could also be added while we're at it but it works as expected so +1 :)

neos/form#87 is now fixed in the form framework via neos/form#88 (release pending) so this reference could be removed here

@kdambekalns kdambekalns changed the title Add maxlength to Text Area view helper FEATURE: Add maxlength to TextArea view helper Oct 23, 2018

@kdambekalns kdambekalns merged commit 0be14c2 into neos:master Oct 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/styleci/pr The analysis has passed
Details

@kdambekalns kdambekalns deleted the robertlemke:bugfix/maxlength-textarea branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment