New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Use localDistributionFolders on ``package:create`` #1433

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
3 participants
@mficzel
Copy link
Member

mficzel commented Nov 7, 2018

If the composer file has a local distribution folder identified by type path and
a local folder reference in the url new packages are created in the
distributionFolder and are required via composer require ... @dev.

@mficzel mficzel requested a review from kitsunet Nov 7, 2018

@mficzel mficzel added this to To do in Neos 4.2 & Flow 5.2 Release Board via automation Nov 7, 2018

@mficzel mficzel moved this from To do to Needs review in Neos 4.2 & Flow 5.2 Release Board Nov 7, 2018

@mficzel mficzel force-pushed the mficzel:feature/setTargetPathForPackageCreate branch 3 times, most recently from 413485c to 77e68ba Nov 8, 2018

FEATURE: Use localDistributionFolders on package:create
If the composer file has a local distribution folder identified by type "path" and
a local folder reference in the "url" the new package is created in the
distributionFolder and the new package is required via composer require.

@mficzel mficzel force-pushed the mficzel:feature/setTargetPathForPackageCreate branch from 77e68ba to 3224fc1 Nov 8, 2018

@mficzel mficzel changed the title FEATURE: Add packagesPath option to the package:create and kickstart:package command FEATURE: Use localDistributionFolders on package:create Nov 8, 2018

@mficzel mficzel changed the title FEATURE: Use localDistributionFolders on package:create FEATURE: Use localDistributionFolders on ``package:create`` Nov 8, 2018

@mficzel mficzel merged commit 39abcd7 into neos:master Nov 8, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Neos 4.2 & Flow 5.2 Release Board automation moved this from Needs review to Done Nov 8, 2018

@kitsunet

This comment has been minimized.

Copy link
Member

kitsunet commented Nov 21, 2018

What could ever go wrong.. My bad should've thought this through, but you cannot run unit tests with an installation with distribution packages anymore as it will start composer when the unit test creates a package... I guess we need to fix this ASAP.

@mficzel

This comment has been minimized.

Copy link
Member

mficzel commented Nov 21, 2018

@kitsunet is there an option to run the unit tests with a specified packagePath. Since the composer behavior is not wrong per se that should help aswell.

@kitsunet

This comment has been minimized.

Copy link
Member

kitsunet commented Nov 21, 2018

Yes, I am trying that atm. At least composer doesn't run anymore. Still get a million errors. But trying to figure that out atm.

kitsunet added a commit to kitsunet/flow-development-collection that referenced this pull request Nov 21, 2018

BUGFIX: Tests adapted to new behavior in PackageManger
The ``PackageManager::createPackage`` method now can create
packages into a possibly existing ``DistributionPackages``
directory "automagically", which then triggers a composer update.
While this is a good idea to push the idea of distribution packages
it also breaks tests that clearly do not want to run composer
update. This can be fixed by providing a defined package path.

Related neos#1433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment