Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
BUGFIX: Properly parse `DateTimeImmutable` types #1442
Currently, a type string of
Note that this is a hotfix at most, because the real issue is, that the regex does not check for a type ending character, like whitespace, line end or another non-word character. Therefore, it eagerly parses
referenced this pull request
Nov 16, 2018
skurfuerst left a comment
makes sense for me so far. I'd say appending the regex with "$" should be fine, though this might have bigger implications so that patch should IMHO be tested on real world projects if needed beforehand.
So first let's get this in I'd say :)
Nov 25, 2018
That change seems to break doctrine entities with
(Neos master, doctrine ORM 2.6.3)
This basically just oncovered the buggy type parser. This in itself led to DateTimeImmutable types no longer being automatically mapped to
Edit: Wait, this BUGFIX is in 4.3, but #1401 is only in 5.0+... means we basically have a "breaking" 4.3 patch release up our sleeves...
Fortunately it's not released yet. Since