Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Update Doctrine DBAL dependency to 2.8 #1444

Merged
merged 2 commits into from Nov 29, 2018
Merged

Conversation

albe
Copy link
Member

@albe albe commented Nov 16, 2018

Because DBAL 2.8 has no backward compatibility breaks, we update this dependency.

For more informations go to https://github.com/doctrine/dbal/releases/tag/v2.8.0

Since DBAL 2.8 has no b/c breaks, it should be safe to update the version.

See https://github.com/doctrine/dbal/releases/tag/v2.8.0

In the longer term, we should also phase out the doctrine/common dependency.
See https://www.doctrine-project.org/2018/07/12/common-2-9-and-dbal-2-8-and-orm-2-6-2.html
@albe
Copy link
Member Author

albe commented Nov 16, 2018

@kdambekalns should we maybe do ~2.7.0|~2.8.0 (or similar) instead?

@kitsunet
Copy link
Member

Seems some more dependencies need to be updated.

@albe
Copy link
Member Author

albe commented Nov 23, 2018

doctrine/common was too strict. Maybe we could even increase the minimum doctrine/common dependency, since DBAL 2.7 requires "doctrine/common": "^2.7.1". Tests pass now.

@kdambekalns kdambekalns merged commit 4574c61 into neos:master Nov 29, 2018
@kdambekalns kdambekalns deleted the dbal-update branch November 29, 2018 14:19
albe added a commit to neos/neos-development-collection that referenced this pull request Nov 30, 2018
See neos/flow-development-collection#1444
doctrine/commons is deprecated, so it's okay to open up the version constraint.
@jonnitto
Copy link
Member

jonnitto commented Dec 6, 2018

Original PR text:

Since DBAL 2.8 has no b/c breaks, it should be safe to update the version.

See https://github.com/doctrine/dbal/releases/tag/v2.8.0

In the longer term, we should also phase out the doctrine/common dependency.
See https://www.doctrine-project.org/2018/07/12/common-2-9-and-dbal-2-8-and-orm-2-6-2.html
AFAIS we only depend on Doctrine\Common\Util\Debug which we are suggested to replace with > > symfony/var-dumper.

neos-bot pushed a commit to neos/media that referenced this pull request Dec 22, 2018
See neos/flow-development-collection#1444
doctrine/commons is deprecated, so it's okay to open up the version constraint.
neos-bot pushed a commit to neos/media-browser that referenced this pull request Dec 22, 2018
See neos/flow-development-collection#1444
doctrine/commons is deprecated, so it's okay to open up the version constraint.
neos-bot pushed a commit to neos/media-browser that referenced this pull request Oct 30, 2020
See neos/flow-development-collection#1444
doctrine/commons is deprecated, so it's okay to open up the version constraint.
neos-bot pushed a commit to neos/media that referenced this pull request Dec 4, 2020
See neos/flow-development-collection#1444
doctrine/commons is deprecated, so it's okay to open up the version constraint.
neos-bot pushed a commit to neos/media-browser that referenced this pull request Dec 4, 2020
See neos/flow-development-collection#1444
doctrine/commons is deprecated, so it's okay to open up the version constraint.
neos-bot pushed a commit to neos/media-browser that referenced this pull request Oct 7, 2022
See neos/flow-development-collection#1444
doctrine/commons is deprecated, so it's okay to open up the version constraint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants