Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
BUGFIX: Support the parser halt fluid token #1450
I changed the target branch, since 4.1 to 4.2 are in security-fix-only mode by now.
Here is the remaining oridignal PR comment:
How to verify it
Trying to reproduce will produce the expected behavior (see the issue)
@kdambekalns i always get these wrong, sorry
@bwaidelich They should rather be called TemplatePreProcessors, because that's what they actually do. They do stuff like CDATA section protection (in Neos.FluidAdaptor. Fluid standalone would drop them), check registered namespaces as xmlns declaration and/or old style namespace declaration in (curly) braces and remove them from the rendering as well as the html tag if it has the
@albe You're welcome.
All together thanks for the approvals (and upcoming merge)
An important feature of Fluid was always that a template was self-contained (i.e. you don't need any context to know how the template works). Pre processors are a nice feature but IMO they should not be configurable. At least not too easily :) otherwise you could break a totally unrelated part by changing the configuration.