Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Avoid strlen call on null value #1463

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@kdambekalns
Copy link
Member

kdambekalns commented Nov 29, 2018

The CropViewHelper should gracefully handle null values
internally. Otherwise you get Argument 1 passed to Neos\Utility\Unicode\Functions::strlen() must be of the type string, null given errors.

BUGFIX: Avoid strlen call on null value
The `CropViewHelper` should gracefully handle `null` values
internally. Otherwise you get `Argument 1 passed to
Neos\Utility\Unicode\Functions::strlen() must be of the type string,
null given` errors.
@kitsunet
Copy link
Member

kitsunet left a comment

I like!

@albe

albe approved these changes Nov 29, 2018

Copy link
Member

albe left a comment

Easy thing.

@albe albe merged commit 4fc6b6f into neos:4.3 Nov 29, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kdambekalns kdambekalns deleted the kdambekalns:bugfix/crop-null-value branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.