Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Revert merge #1442 from neos/albe-typehandling-fix #1466

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
3 participants
@kdambekalns
Copy link
Member

kdambekalns commented Nov 30, 2018

This reverts commit f92ec40, reversing
changes made to a00a751.

See #1442

BUGFIX: Revert merge #1442 from neos/albe-typehandling-fix
This reverts commit f92ec40, reversing
changes made to a00a751.
@albe

albe approved these changes Nov 30, 2018

Copy link
Member

albe left a comment

Thanks for taking care!

@albe albe merged commit e786d86 into neos:4.3 Nov 30, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@albe

This comment has been minimized.

Copy link
Member

albe commented Nov 30, 2018

Should we upmerge this and create a new PR in 5.0 that does un-revert, or should we just skip upmerging this commit?

@kdambekalns

This comment has been minimized.

Copy link
Member Author

kdambekalns commented Nov 30, 2018

@albe

This comment has been minimized.

Copy link
Member

albe commented Nov 30, 2018

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.