Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Support "/" in file upload fields #1469

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@futape
Copy link

futape commented Dec 4, 2018

Adds support for file uploads with "/"s in their names.
Adds a Request::calculateFieldPathsAsArray method
returning the paths as arrays instead of "/"-separated strings
(later "/"-split again).
Keeps the calculateFieldPaths method returning the paths as
strings for backwards-compatibility.

Fixes #1467

@daniellienert

This comment has been minimized.

Copy link
Member

daniellienert commented Dec 7, 2018

@futape: Looks good as far as I can see, but someone with more knowledge in the HTTP should approve it. A test for that case could help.

@futape futape force-pushed the futape:bugfix/untangle-files-array-4-3 branch from 62c4a66 to 510a5f4 Dec 7, 2018

@albe
Copy link
Member

albe left a comment

Hey, thanks a lot for this and congrats on your first contribution! The code looks really good. I'd love to see a test though, that somehow shows the previous illbehaviour. Can you take a look? If you have problems or feel unsafe about things, feel free to ask here or on slack.

@futape

This comment has been minimized.

Copy link
Author

futape commented Dec 28, 2018

will tackle this in january 2019.

@futape futape force-pushed the futape:bugfix/untangle-files-array-4-3 branch from 0f154f6 to 643878c Jan 4, 2019

@futape

This comment has been minimized.

Copy link
Author

futape commented Jan 4, 2019

@albe i've just added the test

@albe

albe approved these changes Jan 9, 2019

Copy link
Member

albe left a comment

Thanks for taking care! Looks good to me.

@futape

This comment has been minimized.

Copy link
Author

futape commented Jan 11, 2019

please also have a look at #1468

@albe albe requested review from bwaidelich and kitsunet Jan 11, 2019

@bwaidelich
Copy link
Member

bwaidelich left a comment

Looks good by reading - just two nit picks (...you are free to ignore)

Show resolved Hide resolved Neos.Flow/Classes/Http/Request.php
Show resolved Hide resolved Neos.Flow/Classes/Http/Request.php Outdated

@futape futape force-pushed the futape:bugfix/untangle-files-array-4-3 branch from 643878c to 5ca9098 Jan 13, 2019

Lucas Krause and others added some commits Dec 4, 2018

BUGFIX: Support "/" in file upload fields
Adds support for file uploads with "/"s in their names.
Adds a `Request::calculateFieldPathsAsArray` method
returning the paths as arrays instead of "/"-separated strings
(later "/"-split again).
Keeps the `calculateFieldPaths` method returning the paths as
strings for backwards-compatibility.

Fixes #1467

@futape futape force-pushed the futape:bugfix/untangle-files-array-4-3 branch from 5ca9098 to 862146a Jan 13, 2019

@daniellienert daniellienert merged commit 4eeda0a into neos:4.3 Jan 14, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.