New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Verify the existence of the `repositories` section in the composer manifest before searching for local packages path #1492

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@mficzel
Copy link
Member

mficzel commented Jan 8, 2019

In older setups that did not have a repositories section in the composer-maifest package:create tried to foreach over a null-value which lead to an php-error. This change checks that the repositories is actually an array before iterating.

BUGFIX: Verify the existence of the `repositories` section in the com…
…poser manifest before searching for local packages path

In older setups that did not have a `repositories` section in the composer-maifest `package:create` tried to iterate on null before which
obviously could not work. This change checks that the `repositories` is actually an array before iterating.

@mficzel mficzel requested review from kitsunet and daniellienert Jan 8, 2019

@mficzel mficzel requested a review from kdambekalns Jan 9, 2019

@albe

albe approved these changes Jan 11, 2019

@albe albe merged commit 7fa722e into neos:5.2 Jan 11, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@albe

This comment has been minimized.

Copy link
Member

albe commented Jan 11, 2019

The "Bug" was introduced 3224fc1#diff-5f91f1e8fceb51b2dd58287631d5606c so the target branch is correct too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment