Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Lower recursion limit for debugger from 50 to 5 #1493

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
4 participants
@mficzel
Copy link
Member

mficzel commented Jan 9, 2019

With the previous recursion limit of 50 php often ran into memory-limits when debugging larger data structures.

BUGFIX: Set recursion limit for Debugger to 5
With the previous recursion limit of 50 php often ran into memory-limits when debugging larger data structures.

@mficzel mficzel requested review from kitsunet , daniellienert and albe Jan 9, 2019

@mficzel mficzel changed the title BUGFIX: Set recursion limit for debugger to 5 BUGFIX: Lower recursion limit for debugger from 50 to 5 Jan 9, 2019

@johannessteu

This comment has been minimized.

Copy link
Contributor

johannessteu commented Jan 9, 2019

Would be a great chance to make this configurable?!

@mficzel

This comment has been minimized.

Copy link
Member Author

mficzel commented Jan 9, 2019

@johannessteu yap there is already a feature pr for that #1490 this here is a bugfix for older neos systems

@kitsunet
Copy link
Member

kitsunet left a comment

YES PLEASE

@albe

albe approved these changes Jan 9, 2019

Copy link
Member

albe left a comment

Thanks!

@albe albe merged commit 4cf9f88 into neos:4.3 Jan 9, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.