New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Add behat @BeforeSuite and @AfterSuite to ignored annotation tags #2726
BUGFIX: Add behat @BeforeSuite and @AfterSuite to ignored annotation tags #2726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isnt this a bugfix and should targed 6.3
?
(then needs to be rebased, changing the branch in the UI doesnt work alone)
Yes, let's get this into 6.3 please. @erickloss can you rebase this PR onto 6.3 or create a new PR please? |
9659b39
to
cdff9a5
Compare
@albe done :) cheers dude |
Thanks a lot @erickloss and congrats on your first contribution :) Edit:
|
it was about time <3 |
What I did
This adds the missing behat annotations to ignored tags, so behat tests using those hooks can be reflected.
How to verify it
This is an example of the error that occurs currently when
@BeforeSuite
or@AfterSuite
is used in any Behat Step class.see also sandstorm/Sandstorm.E2ETestTools#6
This can also be avoided when classes containing those annotations are not reflected, meaning if they are outside the psr classes directory.
When they are inside psr class directories, an error is thrown (see screenshot)