Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Add behat @BeforeSuite and @AfterSuite to ignored annotation tags #2726

Merged
merged 2 commits into from Mar 28, 2022

Conversation

erickloss
Copy link
Contributor

@erickloss erickloss commented Mar 9, 2022

What I did
This adds the missing behat annotations to ignored tags, so behat tests using those hooks can be reflected.

How to verify it
This is an example of the error that occurs currently when @BeforeSuite or @AfterSuite is used in any Behat Step class.
image
see also sandstorm/Sandstorm.E2ETestTools#6
This can also be avoided when classes containing those annotations are not reflected, meaning if they are outside the psr classes directory.
When they are inside psr class directories, an error is thrown (see screenshot)

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isnt this a bugfix and should targed 6.3?

(then needs to be rebased, changing the branch in the UI doesnt work alone)

@mhsdesign mhsdesign changed the base branch from master to 6.3 March 22, 2022 07:42
@mhsdesign mhsdesign changed the title add behat @BeforeSuite and @AfterSuite to ignored annotation tags BUGFIX: Add behat @BeforeSuite and @AfterSuite to ignored annotation tags Mar 22, 2022
@mhsdesign mhsdesign changed the base branch from 6.3 to master March 22, 2022 07:42
@jonnitto jonnitto requested a review from albe March 23, 2022 09:00
@albe
Copy link
Member

albe commented Mar 25, 2022

Yes, let's get this into 6.3 please. @erickloss can you rebase this PR onto 6.3 or create a new PR please?

@erickloss erickloss force-pushed the bugfix/add-ignored-behat-annotations branch from 9659b39 to cdff9a5 Compare March 28, 2022 09:37
@erickloss erickloss changed the base branch from master to 6.3 March 28, 2022 09:38
@erickloss
Copy link
Contributor Author

@albe done :) cheers dude

@albe albe enabled auto-merge March 28, 2022 10:08
@albe
Copy link
Member

albe commented Mar 28, 2022

Thanks a lot @erickloss and congrats on your first contribution :)

Edit:
extraction from the original Description to keep the automatic changelog clean :)

This is my first contribution to this repository, I am unsure if there are any tests for the ignored tags logic (and if I should add some for my change).

Cheers + greetings
Eric

@albe albe merged commit 1dcc1c8 into neos:6.3 Mar 28, 2022
@erickloss
Copy link
Contributor Author

erickloss commented Mar 28, 2022

Thanks a lot @erickloss and congrats on your first contribution :)

it was about time <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants