New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: node migration kickstart command #2897
FEATURE: node migration kickstart command #2897
Conversation
$relativeTargetPathAndFilename = substr($targetPathAndFilename, strrpos(substr($targetPathAndFilename, 0, strpos($targetPathAndFilename, 'Tests/') - 1), '/') + 1); | ||
} else { | ||
$relativeTargetPathAndFilename = substr($targetPathAndFilename, strrpos(substr($targetPathAndFilename, 0, strpos($targetPathAndFilename, 'Classes/') - 1), '/') + 1); | ||
if (strpos($targetPathAndFilename, FLOW_PATH_PACKAGES) === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little note about this change.
I had a discussion with @kitsunet about a problem that i had, while working on my ./flow kickstart:nodemigration
feature. The problem was that the output in my generateNodeMigration()
method looked like this:
Created .../Test20220906183945.yaml
Your node migration has been created successfully.
The full path to the file was missing. This was because the generateFile()
method could only handle Resources, Tests and Classes. We refactored the generateFile()
method so that it works the same as before. But now it also can handle the full path to a migration created with the ./flow kickstart:nodemigration
command:
Created .../Sites/Neos.Demo/Migrations/ContentRepository/Test20220907193517.yaml
Your node migration has been created successfully.
b0eb20d
to
de58207
Compare
|
Closing as it needs to be done in another repository. |
Review instructions
This pull request contains a new feature for the
Neos.Kickstarter
package. The new command is:./flow kickstart:nodemigration
. I can provide a$packageKey
. The$packageKey
is the respective site package. It also appends the current$timeStamp
in the format:YmdHis
to the generated migration.Demo:
The node migration is displayed as usual when running:
./flow node:migrationstatus
:The created node migration comes also with a template, which can be customized directly. The template also contains information about the node migration part in the Neos documentation.
Template
Related information:
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions