Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Change default value for maximumPathLength in EnvironmentConfiguration #810

Merged
merged 1 commit into from Jan 9, 2017

Conversation

Nico-at-worxx
Copy link
Contributor

As mentioned in the github/neos/cache is the decalaration of the property maximumPathLength with a value and then requiring a value for that property inside the constructor that overwrites the declared value EVERY time a minor bug. So the parameter for the constructor should be changed to an optional with the deault value as set for declaration

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch

As mentioned in the github/neos/cache is the decalaration of the property maximumPathLength with a value and then requiring a value for that property inside the constructor a minor bug. So the parameter for the constructor should be changed to an optional with the deault value as set for declaration
@mention-bot
Copy link

@NHoeller, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kitsunet to be a potential reviewer.

@dfeyer dfeyer changed the title TASK: change parameter maximumPathLength for constructor TASK: Change default value for maximumPathLength in EnvironmentConfiguration Jan 8, 2017
@dfeyer dfeyer requested a review from kitsunet January 8, 2017 21:43
@dfeyer dfeyer changed the base branch from master to 4.0 January 8, 2017 21:46
@kitsunet kitsunet merged commit 5367892 into neos:4.0 Jan 9, 2017
kitsunet added a commit that referenced this pull request Jan 9, 2017
TASK: Simplify EnvironmentConfiguration object instantiation

in the environmental class "Neos\Cache\EnvironmentConfiguration" is a minor bug (PR #810). in the moment the bug is fixed the parameter $maximumPathLength has not to be set if its equal to the php constant PHP_MAXPATHLEN. In this case it can be removed from the constructor call.
ComiR pushed a commit to ComiR/flow-development-collection that referenced this pull request Aug 17, 2018
TASK: Simplify EnvironmentConfiguration object instantiation

in the environmental class "Neos\Cache\EnvironmentConfiguration" is a minor bug (PR neos#810). in the moment the bug is fixed the parameter $maximumPathLength has not to be set if its equal to the php constant PHP_MAXPATHLEN. In this case it can be removed from the constructor call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants