Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: CKE5 placeholder insert plugin #46

Open
wants to merge 1 commit into
base: master
from

Conversation

@dimaip
Copy link
Member

commented Aug 27, 2019

Requires: neos/neos-ui#2546

Adds a dropdown to CKE5 that allows you to insert Fluid placeholders for elements configured in the current form. It takes either formElement.properties.identifier or formElement.identifier as the placeholder value.

Sample config to enable this feature:

'Neos.Form.Builder:ConfirmationFinisher':
  properties:
    'message':
      ui:
        inspector:
          editor: 'Neos.Neos/Inspector/Editors/RichTextEditor'
          editorOptions:
            formatting:
              placeholderInsert: true
              strong: true
              em: true

image (2)

@dimaip dimaip requested a review from bwaidelich Aug 27, 2019


const placeholderLabel = this.props.i18nRegistry.translate(
"Neos.Form.Builder:Main:placeholder",
"Insert placeholder"

This comment has been minimized.

Copy link
@lorenzulrich

lorenzulrich Aug 27, 2019

This should be localized.

This comment has been minimized.

Copy link
@dimaip

dimaip Aug 27, 2019

Author Member

It is, once the translations will be in place, it would show up, this is just a fallback

const options = elementsNode.children
.map(node => this.props.nodesByContextPath[node.contextPath])
.map(node => ({
value: node.properties.identifier || node.identifier,

This comment has been minimized.

Copy link
@lorenzulrich

lorenzulrich Aug 29, 2019

Would it be possible to have this in Settings? While thinking of it, I see that different use-cases are possible; sometimes you want to use speaking identifiers, sometimes not.

This comment has been minimized.

Copy link
@dimaip

dimaip Aug 29, 2019

Author Member

Could you describe your idea in more details: setting name, setting format, what exactly it does etc?

@markusguenther
Copy link
Member

left a comment

Looks good to me, just wondering with the version constraint to the @neos-project/neos-ui-extensibility.

"watch": "neos-react-scripts watch"
},
"devDependencies": {
"@neos-project/neos-ui-extensibility": "^1.3"

This comment has been minimized.

Copy link
@markusguenther

markusguenther Aug 30, 2019

Member

really version 1.3?

@lorenzulrich

This comment has been minimized.

Copy link

commented Sep 2, 2019

We need to rethink if and when to add this to Form Builder:

  • Form Builder currently supports Neos 3.1+ and the old UI.
  • As far as I know, the old UI is also supported in Neos 4.3, even though I'm not sure if anyone still uses it. If we can remove support for the old UI, we could have a release targeting Neos 4.3+ without support for the old UI.
  • The underlying change in the Neos UI, neos/neos-ui#2546, is only targeting Neos 5. So we would need to have a separate version/branch with Neos 5 only support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.