New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: health status and proper exit code for node:repair #1988

Closed
DrillSergeant opened this Issue Apr 9, 2018 · 1 comment

Comments

Projects
3 participants
@DrillSergeant
Copy link
Contributor

DrillSergeant commented Apr 9, 2018

It would ne nice to use the dry-mode to monitor the health of nodetrees. For that case it would be helpful if the command returns an errorcode > 0 if something needs to be done.

@bwaidelich

This comment has been minimized.

Copy link
Member

bwaidelich commented Oct 18, 2018

Good idea, but I suggest to add a new command for that, s.th. like node:status

@bwaidelich bwaidelich changed the title Proposal: Let node:repair return an errorcode when appropriate FEATURE: health status and proper exit code for node:repair Nov 15, 2018

@bwaidelich bwaidelich self-assigned this Nov 15, 2018

@bwaidelich bwaidelich added this to To do in Neos 4.2 & Flow 5.2 Release Board via automation Nov 15, 2018

@bwaidelich bwaidelich moved this from To do to In progress in Neos 4.2 & Flow 5.2 Release Board Nov 15, 2018

bwaidelich added a commit to bwaidelich/neos-development-collection that referenced this issue Nov 16, 2018

FEATURE: health status and proper exit code for node:repair
This is a backwards compatible rework of the `node:repair` command.

This introduces a new `EventDispatchingNodeCommandControllerPluginInterface`
that can be implemented by NodeCommandControllerPlugins in order to
dispatch repair events instead of having to interact with the console
output directly.

The two provided core plugins now implement this interface and dispatch
corresponding events.

Background:
This rework allows the Command Controller to control the execution of tasks
and the rendering of their output which allows for a more streamlined
console output and serves as basis for further improvements (e.g. verbosity
flag).
This also fixes the exit code of the command, that is now 1 if one of the
commands triggered an error.

Resolves: neos#1988

Neos 4.2 & Flow 5.2 Release Board automation moved this from In progress to Done Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment