Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neos requires Neos.Setup package #2618

Closed
bwaidelich opened this issue Jul 31, 2019 · 6 comments

Comments

@bwaidelich
Copy link
Member

commented Jul 31, 2019

Description

Currently the neos/setup package can't be uninstalled because neos/neos depends on it.

Reson for this hard dependency are the Step-implementations that break the proxy building if the corresponding base classes can't be found.

@bwaidelich

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

Maybe this can be solved by adding a @Flow\Proxy(false) annotation to the Step-classes. If that doesn't work they have to be moved to a separate package probably

@bwaidelich

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

Maybe this can be solved by adding a @flow\Proxy(false) annotation to the Step-classes

I just gave it a shot and it won't work and results in a

Required class "Neos\Neos\Setup\Step\AdministratorStep" could not be loaded properly for reflection.

exception during compilation.

A separate package (maybe Neos.Neos.Setup?) with the step implementations and configuration should work though

@kitsunet

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

I am somewhat sure we should have a ticket about this somewhere. And yes, a separate package would be the only way to solve this, unless we somehow change the way steps interact with the package (probably difficult as you want at least some interface to contract to).

@bwaidelich

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

I am somewhat sure we should have a ticket about this somewhere

I thought so too, but couldn't find it?

@KovalVV

This comment has been minimized.

Copy link

commented Jul 31, 2019

When I was discussing fixing the issue just for myself at https://discuss.neos.io/t/is-it-possible-to-disable-or-hide-neos-setup-in-a-friendly-reversible-manner/4442 , I was thinking about forced rerouting of <website>/setup to <website>/neos or just to <website>/ .

As long as is <website>/setup cannot be accessed, I don't really care about the package itself.

Is my way simpler and/or possible at all? :-)

@bwaidelich

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

@KovalVV you can of course change your server setup to redirect /setup but it won't work with the Flow Routing configuration because the /setup route is triggered via a custom RequestHandler (see https://github.com/neos/setup/blob/master/Classes/Core/RequestHandler.php#L42).

As work around for this, we could introduce some flag Neos.Setup.enable to the Settings.yaml but I'd prefer to make this package uninstallable

bwaidelich added a commit to bwaidelich/neos-development-collection that referenced this issue Aug 2, 2019

FEATURE: Make Neos independent from Setup package
Removes the `neos/setup` composer dependency from the `neos/neos` package
and adds a root dependency to the new `neos/neos-setup` package that now
contains configuration and custom "setup step" implementations.

Resolves: neos#2618

@bwaidelich bwaidelich added this to To do in Neos 5.0 & Flow 6.0 Release Board via automation Aug 2, 2019

@bwaidelich bwaidelich moved this from To do to Needs review in Neos 5.0 & Flow 6.0 Release Board Aug 2, 2019

Neos 5.0 & Flow 6.0 Release Board automation moved this from Needs review to Done Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.