Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Frontend Routing for the backend preview #2653

Closed
bwaidelich opened this issue Aug 23, 2019 · 0 comments · Fixed by #2654
Closed

Don't use Frontend Routing for the backend preview #2653

bwaidelich opened this issue Aug 23, 2019 · 0 comments · Fixed by #2654

Comments

@bwaidelich
Copy link
Member

@bwaidelich bwaidelich commented Aug 23, 2019

At some point a special URL syntax some/path@some-workspace;<some-dimensionkey>=<some-dimensionvalue>;... was introduced in order to reuse the frontend routing to render the preview within the Neos Backend.

I suggest to reconsider this decision and to introduce a single route for those "non-live-previews" with a syntax like /neos/preview?node=<some-node-context-path> (similar to the recently introduced /neos/redirect?node=...) for the following reasons:

  • We currently create cache entries for every combination of "preview URLs" (with the change it will be only one for /preview because query params are ignored)
  • Faster Backend navigation (because we don't need to use the redirect route everywhere)
  • The current behavior lead to many bugs (#939, neos/neos-ui#1698, #2652, #2347, and probably many more)
  • With a different route (and action) we could greatly simplify the code of NodeController and FrontendRoutePartHandler and make way for new features like partial matching (#780), multi-format-support (#870) dedicated workspace previews, ...
bwaidelich added a commit to bwaidelich/neos-development-collection that referenced this issue Aug 23, 2019
bwaidelich added a commit to neos/neos-ui that referenced this issue Aug 23, 2019
@davidspiola davidspiola added this to To do in Neos 5.1 & Flow 6.1 Release Board via automation Nov 7, 2019
@bwaidelich bwaidelich added Feature and removed Bug labels Nov 28, 2019
@bwaidelich bwaidelich moved this from To do to Review in progress in Neos 5.1 & Flow 6.1 Release Board Nov 29, 2019
@bwaidelich bwaidelich removed this from Review in progress in Neos 5.1 & Flow 6.1 Release Board Nov 29, 2019
bwaidelich added a commit to neos/neos-ui that referenced this issue Dec 2, 2019
Neos 5.1 & Flow 6.1 Release Board automation moved this from Reviews needed to Done Dec 2, 2019
bwaidelich added a commit to neos/neos-ui that referenced this issue Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.