TASK: Defer initialisation of NodePriviliges #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aertmann
reviewed
Feb 7, 2018
| */ | ||
| protected function buildCacheEntryIdentifier() | ||
| { | ||
| $this->cacheEntryIdentifier = md5($this->privilegeTarget->getIdentifier() . '__methodPrivilege' . '|' . $this->buildMethodPrivilegeMatcher()); |
There was a problem hiding this comment.
any reason not to use the existing getPrivilegeTargetIdentifier instead of $this->privilegeTarget->getIdentifier() method here?
There was a problem hiding this comment.
@kitsunet Can you clarify this? Is that needed due to lazy initialisation or something?
There was a problem hiding this comment.
by testing look like calling getPrivilegeTargetIdentifier doesn't make any difference.
There was a problem hiding this comment.
I think there were edge cases in which using getPrivilegeTargetIdentifier triggered additional initialisations that were not really needed.
dfeyer
approved these changes
Apr 18, 2018
|
@kitsunet What about this, re-target to 5.0? |
kdambekalns
approved these changes
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.