[TASK] Media browser performance improvements #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Example of optimized query vs. |
| } else { | ||
| $queryString = 'SELECT count(a.persistence_object_identifier) c FROM typo3_media_domain_model_asset a LEFT JOIN typo3_media_domain_model_asset_tags_join tagmm ON a.persistence_object_identifier = tagmm.media_asset LEFT JOIN typo3_media_domain_model_assetcollection_assets_join collectionmm ON a.persistence_object_identifier = collectionmm.media_asset WHERE tagmm.media_tag = ? AND collectionmm.media_assetcollection = ?'; | ||
| $queryString = 'SELECT count(a.persistence_object_identifier) c FROM typo3_media_domain_model_asset a LEFT JOIN typo3_media_domain_model_asset_tags_join tagmm ON a.persistence_object_identifier = tagmm.media_asset LEFT JOIN typo3_media_domain_model_assetcollection_assets_join collectionmm ON a.persistence_object_identifier = collectionmm.media_asset WHERE tagmm.media_tag = ? AND collectionmm.media_assetcollection = ? AND a.dtype != "typo3_media_imagevariant"'; | ||
| } | ||
|
|
||
| $query = $this->entityManager->createNativeQuery($queryString, $rsm); |
There was a problem hiding this comment.
Does this query work with all supported DBs?
|
left some comments, the rest is fine I guess. |
|
@kitsunet good catch, checked the query on postgres and it fails.. will push follow up |
Including image variants in asset searches returns lots of images that aren't desired since they're simple cropped versions of others.
Related: NEOS-1698
Optimizes the asset repository count queries to remove unnecessary joins resulting in ~10x performance gain. Related: NEOS-1698
Related: NEOS-1698
Resolves: NEOS-1698
Related: NEOS-1698
aertmann
force-pushed
the
media-browser-performance-improvements
branch
from
6f8916e
to
af56539
Compare
|
fixed the queries for postgres 👍 |
|
btw. since there's no functional changes, simply verify that the counts still work and the modal windows (delete asset, delete tag, delete collection) appear and work.. |
|
for reference, this changed the response time from 35 s to 5 s with 6000 assets and ~350 tags |
|
Good stuff, thanks a lot 👍 |
kitsunet
added a commit
that referenced
this pull request
Dec 9, 2015
…vements TASK: Media browser performance improvements Optimizes rendering performance of the media browser/module by re-using modals, optimizing and using count queries. Brings 0,5x-3x+ speed improvement depending on the selected view and amount of assets and tags/asset collections visible. No functional difference. Additionally fixes a couple of bugs in the asset repository. NEOS-1698 #close
|
thanks |
|
i saw this has already been merged, but i still tried to "manually merge" this changes into my 2.0.4 test system (since i got around a thousand assets there to test the behaviour and performance) but unluckily for me these changes seem to depend on other changes not merged into my 2.0.4 instance yet, since i get: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes rendering performance of the media browser/module by
re-using modals, optimizing and using count queries.
Brings 0,5x-3x+ speed improvement depending on the selected view
and amount of assets and tags/asset collections visible.
No functional difference.
Additionally fixes a couple of bugs in the asset repository.
Resolves: NEOS-1698