Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Handle unavailable asset proxies in edit view #2771

Merged

Conversation

@kdambekalns
Copy link
Member

kdambekalns commented Nov 15, 2019

When an asset is not found, some actions threw an 404 status, which
leads to Neos showing the "404 page" under certain circumstances.

This change assigns the exception just like in the case of a connection
error, leaving handling to the media browser.

Now when an asset is not available, the edit template reacts to the
connectionError´. This avoids an error with the format.relativeDate` VH
and informs the user correctly about the fact an asset could not be
found.

kdambekalns added 2 commits Nov 15, 2019
When an asset is not found, some actions threw an 404 status, which
leads to Neos showing the "404 page" under certain circumstances.

This changes assigns the exception just like in the case of a connection
error, leaving handling to the media browser.
When an asset is not available, the template now reacts to the
connectionError. This avoids an error with the relativeDate VH
and informs the user correctly about the fact an asset could not
be found.
Copy link
Member

bwaidelich left a comment

👍 by reading. Nice one!

@kdambekalns kdambekalns merged commit 7efa035 into neos:4.3 Dec 3, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kdambekalns kdambekalns deleted the kdambekalns:bugfix/handle-unavailable-asset-proxies branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.