Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: PHP 7.4 compatibility #2804

Open
wants to merge 4 commits into
base: 4.3
from

Conversation

@kdambekalns
Copy link
Member

kdambekalns commented Dec 2, 2019

@kdambekalns kdambekalns added the T: PHP label Dec 2, 2019
@kdambekalns kdambekalns requested review from bwaidelich, kitsunet and albe Dec 2, 2019
@kdambekalns kdambekalns self-assigned this Dec 2, 2019
@kdambekalns kdambekalns requested a review from robertlemke Dec 2, 2019
@kdambekalns

This comment has been minimized.

Copy link
Member Author

kdambekalns commented Dec 2, 2019

Haha, this still needs PHP 7.4 to be enabled for Travis… feel free, I have to run now.

Copy link
Member

bwaidelich left a comment

👍 by reading

@markusguenther markusguenther mentioned this pull request Dec 2, 2019
0 of 3 tasks complete
kdambekalns added 3 commits Dec 3, 2019
This change

- removes PostgreSQL tests with PHP 7.1
- adds tests on PHP 7.3
- adds tests on PHP 7.4
- switches PostgreSQL 9.4 to 9.5 to tests
PostgreSQL 9.4 will stop being supported in February 2020.
@kdambekalns

This comment has been minimized.

Copy link
Member Author

kdambekalns commented Dec 3, 2019

FYI: The test failures will be fixed with Behat/Transliterator#29

@albe
albe approved these changes Dec 3, 2019
Copy link
Member

albe left a comment

Looks good, but not sure about those test failures - something Gd, rather than Behat/Transliterator, no?

@kdambekalns

This comment has been minimized.

Copy link
Member Author

kdambekalns commented Dec 3, 2019

Haha, right. I only knew Array and string offset access syntax with curly braces is deprecated but the GD error is probably a result of switching to Bionic. Seems GD needs to be installed during setup…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.