Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the editors also in the creating dialog #1034

Closed
jonnitto opened this issue Sep 27, 2017 · 10 comments
Closed

Integrate the editors also in the creating dialog #1034

jonnitto opened this issue Sep 27, 2017 · 10 comments

Comments

@jonnitto
Copy link
Member

At the moment, not all available editors (e.g. DateTime) are available in the creationDialog. In order to make advanced use of https://github.com/Flowpack/Flowpack.NodeTemplates/, it is important to have all of them in the dialog.

@jonnitto
Copy link
Member Author

jonnitto commented Sep 27, 2017

In the properties definition, you need to set the editor inside of the inspector, in the creationDialog not. The editors are available. The editorOptions aren't working, but this is another issue…

@dimaip
Copy link
Contributor

dimaip commented Sep 27, 2017

Hmm actually I'm sure some advanced editors like Image editor won't work, so re-opening.

@dimaip dimaip reopened this Sep 27, 2017
@dimaip
Copy link
Contributor

dimaip commented Sep 27, 2017

Or does image editor work for you?

@jonnitto
Copy link
Member Author

Yes, you are right. The image editor doesn't work correctly.

@bwaidelich
Copy link
Member

I can confirm, that the ImageEditor won't work from the creationDialog: The MediaBrowser won't be shown – this is probably a challenge to achieve UX wise..

@bweinzierl
Copy link

I stumbled across this problem today while using the mentioned Flowpack.NodeTemplates. In my case the ImageEditor and the AssetEditor both cannot open the MediaBrowser. This would be a much needed Feature to greatly improve the backend user experience.

@bwaidelich
Copy link
Member

Since we're planning to integrate the "creation dialog properties" feature into Neos 5.1 (see https://discuss.neos.io/t/rfc-allow-node-properties-to-appear-in-the-creation-dialog/3687) this issue will get more relevance. Maybe we can come up with an intermediate solution like a custom editor with limited browsing functionality?

@bwaidelich
Copy link
Member

FYI: Currently those are the core editors that don't (completely) work in Creation Dialogs due to the secondary view:

  • Neos.Neos/Inspector/Editors/ImageEditor
  • Neos.Neos/Inspector/Editors/AssetEditor
  • Neos.Neos/Inspector/Editors/RichTextEditor
  • Neos.Neos/Inspector/Editors/CodeEditor

We briefly discussed this in our weekly team meeting yesterday. One (probably simpler but not so UX-y way) might be to open the original modal on top of the Creation Dialog modal.
Alternatively we could maybe expand the secondary view like we currently do with DateTime properties:

image

image

I have no clue how much work that would be.. For now I'll disable those editors for neos/neos-development-collection#2173

@albe albe added this to Backlog in Neos 5.2 & Flow 6.2 Release Board via automation Dec 18, 2019
@albe albe removed this from Backlog in Neos 5.2 & Flow 6.2 Release Board Apr 22, 2020
@Sebobo
Copy link
Member

Sebobo commented Jul 3, 2020

This is also an interesting topic for the new media ui.
Maybe embedding the secondary inspector is the best option.
I anyway wanted to make the media selector fully responsive.

@mficzel mficzel self-assigned this Jan 4, 2021
@mficzel mficzel added this to To do in Neos & Flow 7.1 Release Board via automation Jan 21, 2021
@mficzel mficzel moved this from To do to In progress in Neos & Flow 7.1 Release Board Jan 21, 2021
@mficzel mficzel moved this from In progress to Review in progress in Neos & Flow 7.1 Release Board Mar 1, 2021
@mficzel mficzel moved this from Review in progress to Reviewer approved in Neos & Flow 7.1 Release Board Mar 12, 2021
@mficzel mficzel moved this from Reviewer approved to Done in Neos & Flow 7.1 Release Board Mar 12, 2021
@bwaidelich
Copy link
Member

With #2870 merged this can be closed, right?

@mficzel mficzel closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

6 participants