Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeTypes properties validation feedback kicks in only after properites are populated #1651

Closed
DrNik opened this issue Feb 26, 2018 · 1 comment
Labels
Bug Label to mark the change as bugfix

Comments

@DrNik
Copy link

DrNik commented Feb 26, 2018

Hi Guys,
as mentioned on this post: https://discuss.neos.io/t/neos-react-ui-nodetype-property-validation-issue/3097 there seems to be a bug in Noes React UI property validation mechanism.
Basically validation feedback kicks in only if the properties that needs to be validated are populated (fill in + apply) first.

Steps to reproduce:

  1. Have a NodeType with a property that must be validated, like:
properties:
  [PROPERTY_NAME]:
     [...]
     validation:
        'Neos.Neos/Validation/NotEmptyValidator': []
  1. Apply values to properties leaving the must-be-validated property blank -> modifications get applied without warnings or “failed validation” feedback

  2. Fill in mandatory property and Apply

  3. Empty out the must-be-validated property -> the “validation failed” popup is shown correctly

Tested versions:
Neos: 3.3.4
Neos.UI: 1.0.7

Thanks,
Nicola

@mstruebing mstruebing added the Bug Label to mark the change as bugfix label Mar 1, 2018
@markusguenther
Copy link
Member

Is this still a problem? We worked on validation stuff at the Hamburg Codesprint and with regular fields like the title or url segment it is working fine. Also the create dialog handles this validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Label to mark the change as bugfix
Projects
None yet
Development

No branches or pull requests

3 participants