Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: CKE5 secondary inspector #2546

Merged
merged 2 commits into from Aug 31, 2019

Conversation

@dimaip
Copy link
Member

commented Aug 25, 2019

Docs: neos/neos-development-collection#2662

TODO:

  • e2e tests
  • adjust docs
  • adjust docs in code
  • more polish and testing

Sample config for testing:

"Neos.NodeTypes.Html:Html":
  properties:
    source:
      ui:
        inspector:
          editor: "Neos.Neos/Inspector/Editors/RichTextEditor"
          editorOptions:
            buttonLabel: i18n
            placeholder: "<p>placeholder</p>"
            autoparagraph: true
            linking:
              anchor: true
              title: true
              relNofollow: true
              targetBlank: true
            formatting:
              strong: true
              em: true
              u: true
              sub: true
              sup: true
              del: true
              p: true
              h1: true
              h2: true
              h3: true
              h4: true
              h5: true
              h6: true
              pre: true
              underline: true
              strikethrough: true
              removeFormat: true
              left: true
              right: true
              center: true
              justify: true
              table: true
              ol: true
              ul: true
              a: true

image (1)

@dimaip dimaip marked this pull request as ready for review Aug 27, 2019

@dimaip dimaip requested review from skurfuerst and markusguenther Aug 27, 2019

@dimaip dimaip force-pushed the dimaip:cked-inspector branch from fe6eb0f to 0ad4765 Aug 27, 2019

@dimaip dimaip force-pushed the dimaip:cked-inspector branch from d05ebc7 to cbfe17c Aug 27, 2019

@markusguenther
Copy link
Member

left a comment

Awesome work @dimaip
Really appreciate the work for the new feature.

@dimaip dimaip changed the base branch from 2.x to master Aug 30, 2019

@dimaip dimaip merged commit 50a4c7e into neos:master Aug 31, 2019

6 checks passed

ci/circleci: build_flow_app Your tests passed on CircleCI!
Details
ci/circleci: checkout Your tests passed on CircleCI!
Details
ci/circleci: codestyle Your tests passed on CircleCI!
Details
ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: unittests Your tests passed on CircleCI!
Details
continuous-integration/styleci/pr The analysis has passed
Details

@dimaip dimaip deleted the dimaip:cked-inspector branch Aug 31, 2019

@dimaip

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.