From cf4190e8da73bd948ad83d4c311bd251c494caed Mon Sep 17 00:00:00 2001
From: mhsdesign <85400359+mhsdesign@users.noreply.github.com>
Date: Fri, 16 Feb 2024 16:27:54 +0100
Subject: [PATCH] TASK: Remove `noHomepageException` rendering group

After the previous adjustments the `SiteDetectionFailedException` will only be thrown in fewer cases, the only real reproducible the `/neos/content` route.
The rendering group is a bit overkill only for this thing and also might swallow 500 errors that should be presented as is and not wrapped by a vibrant welcome page.

The ui should be adjusted instead. https://github.com/neos/neos-ui/issues/3721
---
 Configuration/Settings.yaml                |  7 +------
 Resources/Private/Translations/en/Main.xlf | 10 ----------
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/Configuration/Settings.yaml b/Configuration/Settings.yaml
index 81127c05eb..5ad7785a51 100755
--- a/Configuration/Settings.yaml
+++ b/Configuration/Settings.yaml
@@ -471,18 +471,13 @@ Neos:
               - Neos\Flow\Persistence\Doctrine\Exception\DatabaseException
               - Neos\Flow\Persistence\Doctrine\Exception\DatabaseConnectionException
               - Neos\Flow\Persistence\Doctrine\Exception\DatabaseStructureException
-            options: &welcomeTemplate
+            options:
               viewClassName: Neos\Fusion\View\FusionView
               viewOptions:
                 fusionPath: 'Neos/Fusion/DatabaseConnectionExceptions'
                 fusionPathPatterns: ['resource://Neos.Neos/Private/Fusion/Error/Root.fusion']
                 enableContentCache: false
                 templatePathAndFilename: ~
-
-          noHomepageException:
-            matchingExceptionClassNames:
-              - Neos\Neos\FrontendRouting\SiteDetection\SiteDetectionFailedException
-            options: *welcomeTemplate
       debugger:
         ignoredClasses:
           Neos\\Neos\\Domain\\Service\\ContentContextFactory: true
diff --git a/Resources/Private/Translations/en/Main.xlf b/Resources/Private/Translations/en/Main.xlf
index 67649a87f3..78c048608d 100644
--- a/Resources/Private/Translations/en/Main.xlf
+++ b/Resources/Private/Translations/en/Main.xlf
@@ -669,16 +669,6 @@
 				<source>Technical Information</source>
 			</trans-unit>
 
-			<trans-unit id="error.exception.noHomepageException.title" xml:space="preserve">
-				<source>Missing Homepage</source>
-			</trans-unit>
-			<trans-unit id="error.exception.noHomepageException.description" xml:space="preserve">
-				<source>Either no site has been defined, the site does not contain a homepage or the active site couldn't be determined.</source>
-			</trans-unit>
-			<trans-unit id="error.exception.noHomepageException.setupMessage" xml:space="preserve">
-				<source>You might want to set the site's domain or import a new site in the setup.</source>
-			</trans-unit>
-
 			<trans-unit id="error.exception.databaseConnectionExceptions.title" xml:space="preserve">
 				<source>Database Error</source>
 			</trans-unit>