TASK: Add core migration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 tasks
kdambekalns
reviewed
Dec 12, 2016
| */ | ||
| public function up() | ||
| { | ||
| $this->searchAndReplace('TYPO3\TYPO3CR\Search', 'Neos\Flow'); |
There was a problem hiding this comment.
Is this really correct? That replacement looks rather generic…
There was a problem hiding this comment.
damn... thanks a lot for seeing this.. Should not write migrations late at night..
|
@kdambekalns fixed |
daniellienert
approved these changes
Dec 22, 2016
kitsunet
requested changes
Jan 23, 2017
gerhard-boden
force-pushed
the
add-code-migration
branch
from
21882b2
to
c9a00fd
Compare
|
@kitsunet done! |
kitsunet
approved these changes
Jan 23, 2017
|
We should merge this one soonish. Tests failing... maybe requiring wrong depenendencies for tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts code to package renaming from "TYPO3.TYPO3CR.Search" to
"Neos.ContentRepository.Search"