Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts for unchanged product updates #2

Closed
neotsn opened this issue May 27, 2014 · 2 comments
Closed

Alerts for unchanged product updates #2

neotsn opened this issue May 27, 2014 · 2 comments
Assignees
Labels

Comments

@neotsn
Copy link
Owner

@neotsn neotsn commented May 27, 2014

The alerts are still firing for simple "product" updates that don't have any changed outlook information.

@neotsn neotsn added the bug label May 27, 2014
@neotsn neotsn self-assigned this May 27, 2014
@neotsn
Copy link
Owner Author

@neotsn neotsn commented May 27, 2014

I believe the issue is related to parsing the entire html response, which includes the product version list at the top of the HWO report, not just the content of the outlook report itself.

I'll modify the hash creation to only has the report contents specifically, not the curl response.

neotsn added a commit that referenced this issue May 28, 2014
#2 : Fixed - Alerts for unchanged product updates
Documented new template methods, all outlook methods
Updated version number
Comment Cleanup in profile
@neotsn neotsn closed this May 28, 2014
@neotsn
Copy link
Owner Author

@neotsn neotsn commented May 28, 2014

Created the hash based on the result of trim(preg_replace()) - so no excess whitespace on the edges and none internally.

Rewrote the outlook processing method to expect only one result from the pre-tags per url (not fetching the multi-outlook url for this service), and required a fix on the cron page for statement processing (an array of statements, not array of statement arrays)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant