Skip to content

Cargo.lock needs update 0.10.2 #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ck3d opened this issue Nov 6, 2022 · 8 comments
Closed

Cargo.lock needs update 0.10.2 #1628

ck3d opened this issue Nov 6, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@ck3d
Copy link
Contributor

ck3d commented Nov 6, 2022

With package manager Nix the package neovide is built in mode --frozen. This leads to errors, when Cargo.toml and Cargo.lock do not fit:

the lock file Cargo.lock needs to be updated but --frozen was passed to prevent this
...

When version is bumped in Cargo.toml then Cargo.lock needs to be updated. The version of neovide is recorded in the lock file:
https://github.com/neovide/neovide/blob/0.10.2/Cargo.lock#L1342

I had to apply following patch:
https://github.com/NixOS/nixpkgs/pull/199915/files#diff-90fb02ea9ea5dc47f898f3d23c599148b71120cf8b9fc79bf8a5c507863c18d3

@ck3d ck3d added the bug Something isn't working label Nov 6, 2022
@alerque
Copy link
Contributor

alerque commented Nov 7, 2022

Same issue packaging for Arch Linux.

@alerque
Copy link
Contributor

alerque commented Nov 7, 2022

This also happened with 0.10.0 (see #1482). Is there a release checklist or script you run when tagging releases that we can get a cargo update added to, or a CI check run with --frozen that would tip you off when you forget to update it along with Cargo.toml?

@MultisampledNight
Copy link
Contributor

Hm, this is weird. I've set up a checklist at https://neovide.dev/maintainer-cookbook.html#actually-releasing which also includes running cargo update, which I did in fe66dde.

But I just realized what I did wrong. I didn't run cargo build after bumping the version everywhere. Phew, another time another patch release, I'm sorry.

@MultisampledNight
Copy link
Contributor

A CI check is a very good idea, I'll do that.

@MultisampledNight
Copy link
Contributor

0.10.3 is out. I'll try to improve the maintainer cookbook later on, quite busy right now

@alerque
Copy link
Contributor

alerque commented Nov 7, 2022

Fair enough. Thanks for the patch release. Understanding what went wrong will surely help iron out the order for next time around.

@ck3d
Copy link
Contributor Author

ck3d commented Nov 7, 2022

Thanks for the quick response!

@ck3d ck3d closed this as completed Nov 7, 2022
@MultisampledNight
Copy link
Contributor

f93a5f3 added an explicit mention of the need of Cargo.lock added to the bump version commit, and should we somehow manage to miss that, 2c0916e added a CI check which will cry on release with a non-frozen build. Hopefully that'll be enough to avoid this annoying situation in the future, sorry again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants