-
-
Notifications
You must be signed in to change notification settings - Fork 584
Starting point for a website #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This uses the [Juice theme](https://www.getzola.org/themes/juice/), with small customizations. It could be further customized later.
RISS and Makefile are used to pull the website content from various parts of the neovide repository (reusing images and the README.md file for instance)
It can be counter-intuitive to have to make changes outside of the `website` directory, adding documentation and scripting clarify it.
Uses https://github.com/marketplace/actions/zola-deploy-to-pages to build and deploy the website on GitHub Pages. TODO (after merging) * A `TOKEN` need to be set as explained in https://github.com/marketplace/actions/zola-deploy-to-pages#secrets * I’ve tested with https://cljoly.github.io/neovide/, but we need to change this to at least https://neovide.github.io/neovide/.
|
See https://cljoly.github.io/neovide/ for a preview. Things that need to be done right before merge:
|
|
If we want to have a custom domain, I have neovide.eu.org (free domain managed by an non-profit that nether expires, so low-maintenance), I’m willing to update DNS records as may be needed (and to transfer it, although I’m unsure about the process). |
|
Good point. Another option is I could grab up neovide.dev (or .com) and pay for it with sponsorship money. That way it could be a top level domain. What do you think? |
|
Can't say enough how awesome this looks btw :) Thanks so much for pushing this forward |
As you want. .eu.org is in the known public suffix list, so it should behave like say |
I've mostly used the defaults of the theme 😉 |
|
Maybe I'm just being weird, but I'm not in the EU (or uk) and I know people use neovide from all over, so I'm sorta inclined to get a domain which is location agnostic. Idk if .dev does that or not, but I figure its not a bad way to go |
Sure. |
|
Ok I grabbed it up. Its getting late where I'm at, so I'm gonna drop off for now, but this looks good to me :) I see that there is a requirement to add a token. I'll take a look at what that entails soon unless somebody else gets to it sooner. |
|
Awesome, thanks for the review! |
|
Shall we set up the token and merge? I would think the upstream issue with code text is minor enough to be addressed separately. |
|
Done! I will look into what it will take to target the neovide.dev domain to the new website. Thanks again! |
|
I'll send a follow up PR to make Zola generate for neovide.dev (and create the CNAME where GitHub pages expects it.) |


What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.