Browse files

checkhealth: Python: fix VIRTUAL_ENV check (#8628)

Compare `$VIRTUAL_ENV` to `python_bin`.
This is necessary when `g:python_host_prog` is set to an absolute path,
and looking up `pyname` in `$PATH` yields another result.
  • Loading branch information...
blueyed authored and justinmk committed Jun 24, 2018
1 parent ddde747 commit bf6048e81d63c26231209ea82d05fb8e948dc573
Showing with 4 additions and 2 deletions.
  1. +4 −2 runtime/autoload/health/provider.vim
@@ -383,8 +383,10 @@ function! s:check_python(version) abort
" Check if $VIRTUAL_ENV is valid.
if exists('$VIRTUAL_ENV')
if !empty(pyname) && $VIRTUAL_ENV !=# matchstr(exepath(pyname), '^\V'.$VIRTUAL_ENV)
if exists('$VIRTUAL_ENV') && !empty(python_bin)
if $VIRTUAL_ENV ==# matchstr(python_bin, '^\V'.$VIRTUAL_ENV)
call health#report_info('$VIRTUAL_ENV matches executable')
call health#report_warn(
\ '$VIRTUAL_ENV exists but appears to be inactive. '
\ . 'This could lead to unexpected results.',

0 comments on commit bf6048e

Please sign in to comment.