New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the Vim breakindent patch #501

Closed
roryokane opened this Issue Apr 10, 2014 · 5 comments

Comments

Projects
None yet
7 participants
@roryokane
Copy link

roryokane commented Apr 10, 2014

Include the patch described and available for download here:

“It causes wrapped lines to be indented to line up with the start of the line”.

screenshot with indent folding, breakindent, and linebreak

It adds a feature that I’ve always wanted to see in Vim. Though I’ve never actually used this patch’s implementation, because I don’t know how to build Vim with a patch on my system and keep that patch updated through updates of Vim – I just know that I love this feature in the few other editors that support it. It sounds from the Google Groups link that Bram just forgot about it and never got around to adding it. If it were built into NeoVim, that would mean people wouldn’t have to figure out how to add the patch themselves, and NeoVim would have another useful, simple feature.

I don’t know how much porting, if any, the most recent version of the patch would need to work with the current version of NeoVim. It might be directly apply-able, or it might need changing to match recent patches in plain Vim or the refactorings in NeoVim.

@greduan

This comment has been minimized.

Copy link

greduan commented Apr 10, 2014

I 👍 this. :)

While on a similar subject, tab handling (space or actually tab) like how Sublime Text does it would be really nice. It's the best implementation I've seen of it from what I remember.

@gaving

This comment has been minimized.

Copy link

gaving commented Apr 10, 2014

👍

Google groups thread sort of says it all about the state of Vim development.

@roryokane

This comment has been minimized.

Copy link

roryokane commented Apr 10, 2014

@greduan Vim already supports “tab handling (space or actually tab)” like you describe. The relevant options are 'expandtab', 'shiftwidth', 'tabstop', and 'softtabstop'. If you set all of them the way you want, tabs and spaces will work like in Sublime Text. You can see an example of how to set them in my .vimrc.

@roryokane roryokane changed the title Include the Vim breakindent patch Include the Vim breakindent patch [$50] May 5, 2014

@roryokane roryokane added the bounty label May 5, 2014

@cseelus

This comment has been minimized.

Copy link

cseelus commented Jun 26, 2014

+1

The lack of this feature has always bugged me … especially since a perfectly fine patch for this existed for years.

@patrickkettner

This comment has been minimized.

Copy link

patrickkettner commented Jul 22, 2014

Since this finally landed in vim proper, I messed with porting over the patches.

There is a decent number of warnings, and 1 actual err.

I have literally zero C experience, so I don't know if I can ever figure out all of the issues in a way that would be mergable, but it doesn't seem like it would be much of a hassle for anyone who knows what they are doing.

@justinmk justinmk closed this Aug 26, 2014

@tarruda tarruda added the bounty label Aug 26, 2014

@tarruda tarruda changed the title Include the Vim breakindent patch [$50] Include the Vim breakindent patch Sep 8, 2014

Grimy pushed a commit to Grimy/neovim that referenced this issue Jan 7, 2015

Better smart-case query-candidate matching
Previously, "Foo" would match "Foo" but not "FOO". Now it matches both. Bottom
line, an uppercase char matches only uppercase chars but lowercase chars can
match either. We used to insist that lowercase chars in the query match
lowercase chars in the candidate strings IF the query also had uppercase
letters; this was dumb and a poor user experience.

Fixes neovim#501.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment